Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear relationship between URI and device_config #11

Closed
djs55 opened this issue Oct 9, 2014 · 1 comment
Closed

Unclear relationship between URI and device_config #11

djs55 opened this issue Oct 9, 2014 · 1 comment

Comments

@djs55
Copy link
Collaborator

djs55 commented Oct 9, 2014

Currently we have

SR.create sr uri configuration
SR.attach sr uri

and we have per-host "device_config".

Proposal:

  1. set the URI = "device_config:uri"
  2. pass the device_config as 'configuration' (minus 'uri' and 'SRmaster'?)

The documentation should be that 'configuration is passed at create-time only because it affects the creation of the SR. Once an SR is created the configuration is self-evident. To refer to an existing SR, the URI is always sufficient'

@gaborigloi
Copy link
Contributor

The interface has been changed and now attach takes a configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants