smint: [error] SM.feature: unknown feature SR_CACHING (and also ATOMIC_PAUSE)

[gthvn1]

Hello 👋 ,

I didn't see any report about this so I posted it. Hope this is not a duplicated one...
In logs I often see: [error||0 |Registering SMAPIv1 plugins D:2c29f7db688b|smint] SM.feature: unknown feature ATOMIC_PAUSE or the same error but with SR_CACHING instead of ATOMIC_PAUSE.

If I look into the file smint.ml it is true that I didn't see these capabilities in string_to_capability_table. And if I look in the code of the storage manager I see that it is also true that some drivers like NFSSR have it in their capabilities.
So it looks like this error is kind of expected and it also seems that everything is working well despite this error.

So my question is shouldn't it be reported has a warning instead of an error? Any history or enlightenment about this error and/or how these capabilities are managed is welcome :). I can also propose the quick fix if reporting a warning instead of error is the way to go ;-)

Thanks for your help,

[gthvn1]

In fact it seems that it is the commit CA-368437 remove duplicate keys from SM.features that reports it as an error now instead of debug. Is it expected?

edit: error "SM.feature: unknown feature %s" feature ; should be debug "SM.feature: unknown feature %s" feature ; I think.

[psafont]

It seems like it was changed because it looked like an error worth reporting, rather than being a fundamental problem. In fact, the deleted comments from the raw list in the tests indicate that at least two of them are unknown by xapi, so the logline is completely expected.

It might be worth investigating why these two features were never added as recognised, and whether it's worth adding them to the recognised features in some form

[gthvn1]

It might be worth investigating why these two features were never added as recognised, and whether it's worth adding them to the recognised features in some form

👍 Agree. That's why I asked for some history here. So at least it is not a "real" error in the sense that everything is working without these two features. Thx for the precision.