Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed build on Travis shows as Succeeded #90

Closed
drbild opened this issue Mar 24, 2018 · 2 comments · Fixed by #132
Closed

Failed build on Travis shows as Succeeded #90

drbild opened this issue Mar 24, 2018 · 2 comments · Fixed by #132
Assignees

Comments

@drbild
Copy link
Contributor

drbild commented Mar 24, 2018

https://travis-ci.org/xaptum/ecdaa/jobs/357640631

@zanebeckwith
Copy link
Collaborator

It looks like this is due to the --status-bugs flag we use when running scan-build.

This flag causes the scan-build run to return a non-zero return code if any bugs are found (the default behavior is to return the exit code from whatever build command you give it). This is necessary for CI stuff like running it on Travis.

So, I don't know how to get the union of these features: "fail if you find bugs, but also fail if the build itself fails".

I'll have to come back to this. Just wanted to leave this comment for my future self.

@zanebeckwith
Copy link
Collaborator

Currently, scan-build cmake is failing on every build, so we are never running scan-build but the builds continue to show as successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants