Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Improvements #1

Merged
merged 5 commits into from Aug 30, 2015
Merged

Some Improvements #1

merged 5 commits into from Aug 30, 2015

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Aug 29, 2015

Here are some improvements to XLTestLog

  • Set indentation settings to two spaces at the project level
  • Set XLTestLogDev deployment target to iOS 6
  • Remove the XAspect dependency
  • Write to XCTestLog's logFileHandle property instead of stdout
  • Silence some warnings

@0xced
Set indentation settings to two spaces at the project level
0f60931
@0xced
Set XLTestLogDev deployment target to iOS 6.0
e01f002 
This matches XLTestLog’s podspec
@0xced
Remove the XAspect dependency
9ed85f9 
XAspect is a nice library but for a single method replacement `method_setImplementation` should be enough.

This will also greatly simplify the manual installation of XLTestLog.
@0xced
Write to XCTestLog's logFileHandle property instead of stdout
1a5b01e 
Note that this is what the original implementation of `-[XCTestLog testLogWithFormat:arguments:]` does.
@0xced
Silence some warnings
70b12fb
@xareelee
Copy link
Owner

Thanks for your help, @0xced. 👍

xareelee added a commit that referenced this pull request Aug 30, 2015
@xareelee
Merge pull request #1 from 0xced/improvements
85502be 
Some Improvements by @0xced.
@xareelee xareelee merged commit 85502be into xareelee:master Aug 30, 2015
@0xced 0xced deleted the improvements branch August 30, 2015 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xced @xareelee