Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a case_sensitivity keyword arguments to methods relying on pathlib (Python 3.12) #292

Open
etienneschalk opened this issue Dec 9, 2023 · 1 comment

Comments

@etienneschalk
Copy link
Contributor

Motive

In Python 3.12, PurePath.match, Path.glob and Path.rglob now supports a case_sensitivity argument, so that the user have full-control on the behavior of the path matching.

https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.match

Changed in version 3.12: The case_sensitive parameter was added.

https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob

Changed in version 3.12: The case_sensitive parameter was added.

https://docs.python.org/3/library/pathlib.html#pathlib.Path.rglob

Changed in version 3.12: The case_sensitive parameter was added.

By default, None means "use OS defaults"

typically, case-sensitive on POSIX, and case-insensitive on Windows.

Proposal: Since datatree only supports POSIX-paths, the default behaviour in datatree should be case-sensitive.

@TomNicholas
Copy link
Collaborator

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants