Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile URL management #45

Open
davidbrochart opened this issue Aug 3, 2021 · 5 comments
Open

Tile URL management #45

davidbrochart opened this issue Aug 3, 2021 · 5 comments

Comments

@davidbrochart
Copy link
Collaborator

With #44 the base URL is now automatically retrieved from JupyterLab, so in order to handle any other platform a function returning the base URL must be passed in get_base_url.
Closing #42, #40, #39, #37.

@Xabitsuki
Copy link

Xabitsuki commented Oct 13, 2021

Could you please elaborate on how does this applies to the jupyter notebook use-case ? I just ran the introduction notebook with a freshly created environment as you specidified in #39 and still have no data on the map. Many thanks in advance.

@davidbrochart
Copy link
Collaborator Author

I advise not using the Classic Notebook, which is deprecated in favor of JupyterLab or RetroLab.
If you want to use the Classic Notebook, you need to pass a get_base_url argument like this:

def get_base_url(url):
    return "http://localhost:8888"

l = da.leaflet.plot(m, get_base_url=get_base_url)

@Xabitsuki
Copy link

Thanks for the hack, it works !
I do not even understand how since my notebook is running on http://localhost:8892/ and not on 8888.
Regarding the use of Classic Notebook or Lab there are still features that are present on one platform and missing on the other, e.g. "highlight selected word" that is still not implemented on Lab but present in Classic Notebooks see this issue. I guess there are other examples if considering all jupyter nbextensions. Notebooks are still popular.

Anyway, thanks again for the hack and if you need, I would be happy to contribute to implement it.

@davidbrochart
Copy link
Collaborator Author

I do not even understand how since my notebook is running on http://localhost:8892/ and not on 8888

Yes, this is strange 👀

Regarding the use of Classic Notebook or Lab there are still features that are present on one platform and missing on the other

That's true, but nobody is working on the Classic Notebook so it will die eventually.

Anyway, thanks again for the hack and if you need, I would be happy to contribute to implement it.

Implement what?

@Xabitsuki
Copy link

Indeed you are right, forget what I said about implementing this hack I will just move on to Lab and wait for the features to come. Merci pour vos réponses et bonne soirée.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants