Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysFS you swapped the parameters #19

Open
otse opened this issue Jul 10, 2017 · 0 comments
Open

PhysFS you swapped the parameters #19

otse opened this issue Jul 10, 2017 · 0 comments

Comments

@otse
Copy link

otse commented Jul 10, 2017

You switched out two parameters the wrong way.

https://github.com/xarray/osgRecipes/blob/master/integrations/osgdb_physfs/ReaderWriterPhysFS.cpp#L90

PHYSFS_read( handle, &(buffer[0]), filesize, 1 ); should be 1, filesize (no joke)

Other than that, the code was outstanding, small and effective. This vfs tutorial that also uses physfs is too long and complicated. Yours is succinct and near perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant