Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive type referencing #27

Open
omerdemirok opened this issue Nov 12, 2023 · 0 comments
Open

Recursive type referencing #27

omerdemirok opened this issue Nov 12, 2023 · 0 comments

Comments

@omerdemirok
Copy link
Contributor

In the workspace scope spec, there are 2 cases where types are referencing themselves recursively

      description: Object column value
      type: object
      additionalProperties:
        anyOf:
          - type: string
          - type: boolean
          - type: number
          - type: array
            items:
              type: string
          - type: array
            items:
              type: number
          - $ref: '#/components/schemas/DateTime'
          - $ref: '#/components/schemas/ObjectValue'

and

    ProjectionConfig:
      description: A structured projection that allows for some configuration.
      type: object
      properties:
        name:
          description: >-
            The name of the column to project or a reverse link specification,
            see [API
            Guide](https://xata.io/docs/concepts/data-model#links-and-relations).
          type: string
        columns:
          $ref: '#/components/schemas/QueryColumnsProjection'

...

    QueryColumnsProjection:
      type: array
      items:
        oneOf:
          - type: string
          - $ref: '#/components/schemas/ProjectionConfig'

@philkra clarified that

  • ObjectValue is going to be deprecated => manually removed from specs
  • ProjectionConfig => QueryColumnsProjection => ProjectionConfig => This has a legitimate use case. We'll deal with that later. Currently we removed the reference from QueryColumnsProjection manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant