Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remark about the interface for chacha20 #21

Open
UnixJunkie opened this issue Oct 3, 2019 · 0 comments
Open

remark about the interface for chacha20 #21

UnixJunkie opened this issue Oct 3, 2019 · 0 comments

Comments

@UnixJunkie
Copy link
Contributor

Hello,
In Stream.chacha20, I think that the (currently optional) [ctr] argument should be made mandatory.
I feel it is dangerous for users to have both the [iv] and [ctr] have default values.
I don't vote for the [iv] to be mandatory, because of its type it is difficult to increment.
While, for the counter, we can ensure it is unique by always incrementing it (until it loops).
Regards,
F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant