Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Brightness transition only works once after a controller is started #100

Closed
szatmariandras opened this issue Jul 19, 2020 · 3 comments
Closed

[BUG] Brightness transition only works once after a controller is started #100

szatmariandras opened this issue Jul 19, 2020 · 3 comments
Assignees
@xaviml
Labels
bug Something isn't working

Comments

@szatmariandras
Copy link

Bug report

Brightness transition only works once after a controller is started

Description

Hi @xaviml ,

First of all, thank you for creating this add-on, I find it a good idea and super useful.

I have an issue where I want to toggle the brightness of an IKEA bulb with an IKEA dimmer, but it only works one. If I change the configuration then it works again once, and it doesn't until I restart again.
You can see it on the logs that after I go all the way to one end of the brightness spectrum and turn back it will show the triggered button even and that it's running one of the actions, but the brightness doesn't change.

The name of the instances between reloads is different because that's how I triggered the reload of the app.

I added some comments in the logs started with === (reads bottom to up) to show how to process went.

Additional information

  • Devices involved:
    • Model: E1743 (IKEA) as Controller
    • Model: TRADFRI bulb E27 as Light
  • Integration: deconz
  • AppDaemon version: v4.0.3
  • ControllerX version: v3.3.0
  • HACS version (if installed from there): v1.2.2
  • Home Assistant Core version: v0.112.4

AppDaemon app configuration

light_living_corner_dimmer_4:
  log_level: DEBUG
  module: controllerx
  class: E1743Controller
  controller: tradfri_on_off_switch_1
  integration: deconz
  light: light.light_living_room_corner_large
  actions:
    - 1001
    - 2001

Logs

2020-07-19 13:15:21.601772 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:21.596028 INFO light_living_corner_dimmer_4:   - brightness: 1
2020-07-19 13:15:21.588380 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:21.580196 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:21.162511 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:21.157047 INFO light_living_corner_dimmer_4:   - brightness: 26.30
2020-07-19 13:15:21.150724 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:21.141055 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:20.748809 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:20.743743 INFO light_living_corner_dimmer_4:   - brightness: 51.60
2020-07-19 13:15:20.738549 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:20.729566 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:20.323148 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:20.310999 INFO light_living_corner_dimmer_4:   - brightness: 76.90
2020-07-19 13:15:20.303176 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:20.294402 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:19.896166 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:19.890973 INFO light_living_corner_dimmer_4:   - brightness: 102.20
2020-07-19 13:15:19.885771 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:19.875136 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:19.478032 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:19.472863 INFO light_living_corner_dimmer_4:   - brightness: 127.50
2020-07-19 13:15:19.466769 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:19.456317 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:19.044167 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:19.039117 INFO light_living_corner_dimmer_4:   - brightness: 152.80
2020-07-19 13:15:19.033781 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:19.024076 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:18.611778 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:18.603971 INFO light_living_corner_dimmer_4:   - brightness: 178.10
2020-07-19 13:15:18.596530 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:18.586117 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:18.168658 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:18.161268 INFO light_living_corner_dimmer_4:   - brightness: 203.40
2020-07-19 13:15:18.153588 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:18.145164 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:17.664988 INFO light_living_corner_dimmer_4:   - transition: 0.35
2020-07-19 13:15:17.659611 INFO light_living_corner_dimmer_4:   - brightness: 228.70
2020-07-19 13:15:17.654037 INFO light_living_corner_dimmer_4:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:17.648625 INFO light_living_corner_dimmer_4: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:17.632510 INFO light_living_corner_dimmer_4: 🏃 Running `hold_brightness_down` now
2020-07-19 13:15:17.626149 INFO light_living_corner_dimmer_4: 🎮 Button event triggered: `2001`

=== Brightness up, trying brightness down ^^^

2020-07-19 13:15:15.239081 INFO light_living_corner_dimmer_4: 🎮 ControllerX v3.3.0
2020-07-19 13:15:15.231844 INFO AppDaemon: Initializing app light_living_corner_dimmer_4 using class E1743Controller from module controllerx
2020-07-19 13:15:15.167403 INFO AppDaemon: Found 1 total apps
2020-07-19 13:15:15.166111 INFO AppDaemon: App 'light_living_corner_dimmer_4' added
2020-07-19 13:15:15.162426 INFO AppDaemon: App 'light_living_corner_dimmer_3' deleted
2020-07-19 13:15:15.161509 INFO AppDaemon: /config/appdaemon/apps/apps.yaml added or modified
2020-07-19 13:15:15.139404 INFO AppDaemon: Reading config

=== Didn't do anything, reloading ^^^

2020-07-19 13:15:05.823879 INFO light_living_corner_dimmer_3: 🏃 Running `hold_brightness_down` now
2020-07-19 13:15:05.817929 INFO light_living_corner_dimmer_3: 🎮 Button event triggered: `2001`

=== Brightness up, trying brightness down ^^^

2020-07-19 13:15:02.123592 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:15:02.117519 INFO light_living_corner_dimmer_3:   - brightness: 254
2020-07-19 13:15:02.110057 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:02.102296 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:01.691427 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:15:01.686308 INFO light_living_corner_dimmer_3:   - brightness: 228.70
2020-07-19 13:15:01.679361 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:01.669242 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:01.251403 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:15:01.246436 INFO light_living_corner_dimmer_3:   - brightness: 203.40
2020-07-19 13:15:01.241255 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:01.235877 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:00.848196 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:15:00.843021 INFO light_living_corner_dimmer_3:   - brightness: 178.10
2020-07-19 13:15:00.837782 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:00.829152 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:15:00.400675 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:15:00.395022 INFO light_living_corner_dimmer_3:   - brightness: 152.80
2020-07-19 13:15:00.387527 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:15:00.379538 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:59.967473 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:14:59.962239 INFO light_living_corner_dimmer_3:   - brightness: 127.50
2020-07-19 13:14:59.955269 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:59.944854 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:59.526617 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:14:59.521506 INFO light_living_corner_dimmer_3:   - brightness: 102.20
2020-07-19 13:14:59.516447 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:59.507663 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:59.094565 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:14:59.089485 INFO light_living_corner_dimmer_3:   - brightness: 76.90
2020-07-19 13:14:59.084260 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:59.078447 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:58.665785 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:14:58.658449 INFO light_living_corner_dimmer_3:   - brightness: 51.60
2020-07-19 13:14:58.650483 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:58.642499 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:58.167736 INFO light_living_corner_dimmer_3:   - transition: 0.35
2020-07-19 13:14:58.162599 INFO light_living_corner_dimmer_3:   - brightness: 26.30
2020-07-19 13:14:58.157213 INFO light_living_corner_dimmer_3:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:58.151952 INFO light_living_corner_dimmer_3: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:58.138184 INFO light_living_corner_dimmer_3: 🏃 Running `hold_brightness_up` now
2020-07-19 13:14:58.132733 INFO light_living_corner_dimmer_3: 🎮 Button event triggered: `1001`

=== Brightness down, trying brightness up ^^^

2020-07-19 13:14:55.870903 INFO light_living_corner_dimmer_3: 🎮 ControllerX v3.3.0
2020-07-19 13:14:55.863356 INFO AppDaemon: Initializing app light_living_corner_dimmer_3 using class E1743Controller from module controllerx
2020-07-19 13:14:55.799893 INFO AppDaemon: Found 1 total apps
2020-07-19 13:14:55.798165 INFO AppDaemon: App 'light_living_corner_dimmer_3' added
2020-07-19 13:14:55.794280 INFO AppDaemon: App 'light_living_corner_dimmer_2' deleted
2020-07-19 13:14:55.792963 INFO AppDaemon: /config/appdaemon/apps/apps.yaml added or modified
2020-07-19 13:14:55.770481 INFO AppDaemon: Reading config

=== Didn't do anything, reloading ^^^

2020-07-19 13:14:46.096534 INFO light_living_corner_dimmer_2: 🏃 Running `hold_brightness_up` now
2020-07-19 13:14:46.091580 INFO light_living_corner_dimmer_2: 🎮 Button event triggered: `1001`

=== Brightness down, trying brightness up ^^^

2020-07-19 13:14:41.799194 INFO light_living_corner_dimmer_2:   - transition: 0.35
2020-07-19 13:14:41.794053 INFO light_living_corner_dimmer_2:   - brightness: 1
2020-07-19 13:14:41.788733 INFO light_living_corner_dimmer_2:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:41.783408 INFO light_living_corner_dimmer_2: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:41.770273 INFO light_living_corner_dimmer_2: 🏃 Running `hold_brightness_down` now
2020-07-19 13:14:41.766630 INFO light_living_corner_dimmer_2: 🎮 Button event triggered: `2001`

=== Pressing button 0, brightness down (though it was already down) ^^^

2020-07-19 13:14:37.657011 INFO light_living_corner_dimmer_2: 🎮 ControllerX v3.3.0
2020-07-19 13:14:37.648899 INFO AppDaemon: Initializing app light_living_corner_dimmer_2 using class E1743Controller from module controllerx
2020-07-19 13:14:37.592876 INFO AppDaemon: Found 1 total apps
2020-07-19 13:14:37.591975 INFO AppDaemon: App 'light_living_corner_dimmer_2' added
2020-07-19 13:14:37.589392 INFO AppDaemon: App 'light_living_corner_dimmer_1' deleted
2020-07-19 13:14:37.588545 INFO AppDaemon: /config/appdaemon/apps/apps.yaml added or modified
2020-07-19 13:14:37.568878 INFO AppDaemon: Reading config

=== Didn't do anything, reloading ^^^

2020-07-19 13:14:29.643356 INFO light_living_corner_dimmer_1: 🏃 Running `hold_brightness_up` now
2020-07-19 13:14:29.637915 INFO light_living_corner_dimmer_1: 🎮 Button event triggered: `1001`

=== Brightness down, trying brightness up ^^^


2020-07-19 13:14:26.457773 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:26.450852 INFO light_living_corner_dimmer_1:   - brightness: 1
2020-07-19 13:14:26.443339 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:26.435516 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:26.025686 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:26.020079 INFO light_living_corner_dimmer_1:   - brightness: 26.30
2020-07-19 13:14:26.014649 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:26.002251 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:25.593075 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:25.588132 INFO light_living_corner_dimmer_1:   - brightness: 51.60
2020-07-19 13:14:25.580654 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:25.570889 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:25.158811 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:25.153581 INFO light_living_corner_dimmer_1:   - brightness: 76.90
2020-07-19 13:14:25.147108 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:25.136832 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:24.741978 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:24.737030 INFO light_living_corner_dimmer_1:   - brightness: 102.20
2020-07-19 13:14:24.731989 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:24.726903 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:24.320511 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:24.313542 INFO light_living_corner_dimmer_1:   - brightness: 127.50
2020-07-19 13:14:24.305720 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:24.296875 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:23.900451 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:23.893862 INFO light_living_corner_dimmer_1:   - brightness: 152.80
2020-07-19 13:14:23.886466 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:23.878690 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:23.480971 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:23.475278 INFO light_living_corner_dimmer_1:   - brightness: 178.10
2020-07-19 13:14:23.467484 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:23.459347 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:23.049878 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:23.044712 INFO light_living_corner_dimmer_1:   - brightness: 203.40
2020-07-19 13:14:23.039245 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:23.029267 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:22.560198 INFO light_living_corner_dimmer_1:   - transition: 0.35
2020-07-19 13:14:22.554933 INFO light_living_corner_dimmer_1:   - brightness: 228.70
2020-07-19 13:14:22.549749 INFO light_living_corner_dimmer_1:   - entity_id: light.light_living_room_corner_large
2020-07-19 13:14:22.544447 INFO light_living_corner_dimmer_1: 🤖 Service: �[1mlight.turn_on�[0m
2020-07-19 13:14:22.529509 INFO light_living_corner_dimmer_1: 🏃 Running `hold_brightness_down` now
2020-07-19 13:14:22.524574 INFO light_living_corner_dimmer_1: 🎮 Button event triggered: `2001`

=== Pressing button 0, brightness goes down ^^^

2020-07-19 13:14:18.283880 INFO light_living_corner_dimmer_1: 🎮 ControllerX v3.3.0
2020-07-19 13:14:18.276542 INFO AppDaemon: Initializing app light_living_corner_dimmer_1 using class E1743Controller from module controllerx
2020-07-19 13:14:18.216292 INFO AppDaemon: Found 1 total apps
2020-07-19 13:14:18.214911 INFO AppDaemon: App 'light_living_corner_dimmer_1' added

Additional Context

Add any other context or screenshots about the bug here.
@szatmariandras szatmariandras added the bug Something isn't working label Jul 19, 2020
@szatmariandras
Copy link
Author

In the meantime I figured out that if I add the release events as well then it works both directions correctly:

light_living_corner_dimmer_1:
  log_level: DEBUG
  module: controllerx
  class: E1743Controller
  controller: tradfri_on_off_switch_1
  integration: deconz
  light: light.light_living_room_corner_large
  actions:
    - 1001
    - 2001
    - 1003
    - 2003

I'm not sure if it's intentional. Probably not, and definitely not documented :)

@xaviml
Copy link
Owner

xaviml commented Jul 21, 2020

Hi @szatmariandras,

Thank you for the thorough explanation on the bug. What you are mentioning is a bug, since you should be able to go up and down the brightness even if you remove the "release" action.

However, I have to say that I do not recommend using a "hold" action without a "release" since they are meant to go together. If there is no "release" action, there is no way for ControllerX to know when to stop sending requests to HA.

I will look into this and I will let you know :)

Thank you,
Xavi M.

@xaviml
Copy link
Owner

xaviml commented Aug 2, 2020

Hi @szatmariandras,

I found out what the problem was and now it will be fixed for the next release. However, my point still stands about my recommendation of not using hold actions without release ones because hold actions will keep calling HA services until they either:

  • Found a release action to stop them
  • They reach boundaries (for min/max values like brightness for example)
  • They reach a maximum amount of loops (default 20). This was done since there are some circular steps like color wheels that do not have boundaries, so if they keep going because the release was not found, then they would never stop.

Anyway, thank you for reporting this since what you found was a bug and it should not happen.

Cheers,
Xavi M.

@xaviml xaviml closed this as completed in 993d69a Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xaviml xaviml

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szatmariandras @xaviml