Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klipperscreen: stops working after change of font size or theme #90

Closed
xblax opened this issue Mar 23, 2024 · 4 comments
Closed

klipperscreen: stops working after change of font size or theme #90

xblax opened this issue Mar 23, 2024 · 4 comments
Labels
bug Something isn't working klipperscreen Everything related to klipperscreen

Comments

@xblax
Copy link
Owner

xblax commented Mar 23, 2024

After changing these settings in the menu, KlipperScreen just shuts down. No error is shown in the log. After manual restart the settings are applied. I think that might actually be intended behavior, to restart the application for these settings.

We might need a wrapper script to automatically restart KlipperScreen if the process terminates.

I like the large font size setting, I guess no one else tried it yet. Maybe that would even make sense as default.

@xblax xblax added the bug Something isn't working label Mar 23, 2024
@consp consp added the klipperscreen Everything related to klipperscreen label Mar 23, 2024
@consp
Copy link
Collaborator

consp commented Mar 23, 2024

Good point, I'll have a look. Thought I tested it but maybe that was with running it manually and forgetting about it.

@consp
Copy link
Collaborator

consp commented Mar 23, 2024

Large also looke better yes

@consp
Copy link
Collaborator

consp commented Mar 23, 2024

It's a bug.

Traceback (most recent call last):
  File "/root/printer_software/KlipperScreen/screen.py", line 13, in <module>
    import gi
ModuleNotFoundError: No module named 'gi'

Tries to start with common python3 not the venv, can be fixed in the script

fix/klipperscreen-restart Wrapper script just to be sure, sourcing the venv fixes the restart but there might be actual "restarts" with exit 0 somewhere in which cast it will also continue. other exit codes stop the script.

@xblax
Copy link
Owner Author

xblax commented Mar 24, 2024

Added to master and cleaned-up the branch. Can be closed.

@xblax xblax closed this as completed Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working klipperscreen Everything related to klipperscreen
Projects
None yet
Development

No branches or pull requests

2 participants