Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFS client support #45

Closed
KaruroChori opened this issue Mar 10, 2024 · 8 comments
Closed

NFS client support #45

KaruroChori opened this issue Mar 10, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@KaruroChori
Copy link
Collaborator

I thought nfs was build into the kernel already but i could be mistaken? Maybe just the user space parts missing. Good point though. Maybe make a separate issue for it @KaruroChori ?

Originally posted by @consp in #17 (comment)

On debian-based systems I always have to install additional packets including executables like mount.nfs, so I think there is some userspace stuff missing.
I cannot check it right now, so I will update this at a later date.

@KaruroChori KaruroChori changed the title I thought nfs was build into the kernel already but i could be mistaken? Maybe just the user space parts missing. Good point though. Maybe make a separate issue for it @KaruroChori ? NFS client support Mar 10, 2024
@KaruroChori KaruroChori added the enhancement New feature or request label Mar 10, 2024
@consp
Copy link
Collaborator

consp commented Mar 11, 2024

I tested it and with the nfs utils installed nfs3 and nfs4 mounts work. It does however, by default, in stall the S60nfs startup script to boot nfsd. I removed that for testing since running a nfs server might not be the best idea. Maybe just do that in the buildroot_post script.

@consp
Copy link
Collaborator

consp commented Mar 11, 2024

Added a line to the buildroot script removing the S60nfs (unless you really...really...really want a nfs server running with one user, namely root, on an insecure device).

It's in the feature/nfs branch. It requires selection of the nfs packages which have been added to the defconfig in a feature branch on the buildroot.

Won't merge it for now until the beta is running, can be done after that.

@KaruroChori
Copy link
Collaborator Author

Great! I cannot think of a realistic workflow for which the nfs server running directly on the printer is a good thing. Probably no one will ever complain :D.

At least in my use-case, the main reason to have a nfs share is so I can use the same gcode across multiple printers. It also simplifies the process of generating gcode in batch from my workstation, as I hate to manually move files around via the webui :D.
Hopefully I am not the only person that lazy.

@consp
Copy link
Collaborator

consp commented Mar 11, 2024

nfs share is so I can use the same gcode across multiple printers

Even if you have one that can be a thing. All my gcode is on a server as well but only for backup, also nfsv4. I can imagine the usecase of someone wanting to cut out the middle man (slicer sending it to moonraker).

If you want to test it get the klipperscreen build since I accidentally already installed nfs there. Note: fstab is currently not safe for reinstall (as in, gets wiped) but adding a mount should not be too much of an issue I guess. You can also use the usb overlay (see install.md when finished). I'm not certain you want to auto-mount after upgrade but maybe that is a thing people want to have.

Can github open a counter for tracking how long it takes till someone requests smbclient? 🤣

@KaruroChori
Copy link
Collaborator Author

I will find a workaround for the fstab entries. Otherwise I am sure I will forget about it next time I upgrade the firmware, so I better fix it for good :D.

The next stage is to use cheap thin clients as klipper hosts, with v-pro enabled for remote management, and to boot via PXE :D.
In all seriousness, I always wondered how big print farms handles their infrastructure.

@xblax
Copy link
Owner

xblax commented Mar 24, 2024

Noticed that the NFS Server Daemon can be disabled separately, therefore removed it from the build:
73cd74b

@consp
Copy link
Collaborator

consp commented Mar 25, 2024

Noticed that the NFS Server Daemon can be disabled separately, therefore removed it from the build: 73cd74b

Completely missed that, must have read it as RPC client. That is a way better option.

@xblax
Copy link
Owner

xblax commented Mar 27, 2024

I'm going to close this since NFS client support was added and no open points at the moment. If there should be any issues this can be re-opened or tracked separately.

@xblax xblax closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants