Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to rename M25 #82

Closed
johncotten opened this issue Mar 19, 2024 · 3 comments
Closed

Need to rename M25 #82

johncotten opened this issue Mar 19, 2024 · 3 comments

Comments

@johncotten
Copy link

johncotten commented Mar 19, 2024

When using Orca and inserting a pause, it sends command M25. Printer does not want to resume and gives error: "Print is not paused, resume aborted".

I inserted this following code into macros and that behavior disappears.

[gcode_macro M25]
rename_existing: M25.1
gcode:
  PAUSE

@xblax
Copy link
Owner

xblax commented Mar 19, 2024

Do we know that's the difference between the M25 and the PAUSE?
M25 is "Pause SD print", the error "Print is not paused, resume aborted" I would maybe expect from M24 "Start/resume SD print". Anyway, probably both should be handled:

[gcode_macro m24]
rename_existing: M24.6245197
gcode:
  {% if printer.pause_resume.is_paused %}
  RESUME
  {% else %}
  M24.6245197
  {% endif %}

[gcode_macro m25]
rename_existing: M25.6245197
gcode:
  PAUSE

Found this example here https://github.com/jschuh/klipper-macros/blob/main/pause_resume_cancel.cfg

@johncotten
Copy link
Author

johncotten commented Mar 19, 2024

That maybe the answer. The resume command and resume button do not send a M24 command. The PAUSE command is preferable anyway because it doesn't leave the nozzle in place to ooze onto the print, plus we are probably doing the pause for filament change anyways...
So I would agree adding both commands would be ideal.

Verified those macros work.

@xblax xblax closed this as completed in 12cdc38 Mar 21, 2024
@xblax
Copy link
Owner

xblax commented Mar 21, 2024

I added these macros, will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants