Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH] Inform Kodi when advertisements are playing #1207

Closed
dapharsyde opened this issue Apr 4, 2023 · 4 comments
Closed

[DASH] Inform Kodi when advertisements are playing #1207

dapharsyde opened this issue Apr 4, 2023 · 4 comments

Comments

@dapharsyde
Copy link

Logging this issue as a feature request for the team to consider adding the detection of advertisements via SCTE-35 markers or similar, and informing Kodi of this in the chapter/period. If this feature is implemented, Kodi could add a new setting that automatically mutes the audio during advertisements detected using this method.

@matthuisman - please help add any additional context to this request, this is my first time creating a github issue - thanks!

@CastagnaIT
Copy link
Collaborator

@enen92 iirc you have worked for something related this?
are you aware if this is supported for binary addons?

@enen92
Copy link
Member

enen92 commented Apr 5, 2023

Nop not really @CastagnaIT I fixed mute actions in EDL which were broken before, and also spent a bit of time understanding EDL implementation in general. My guess is that the way to go is to extend the EDL interface and allow addons to set new edits. I was thinking about doing this a bit more statically by allowing the addon to set a property with a list of edits. However, as far as I can understand the request here is a bit more dynamic...
Currently this is not possible at all

@CastagnaIT
Copy link
Collaborator

thanks so in near future its not possible do nothing about this
then i close it

@CastagnaIT CastagnaIT closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
@dapharsyde
Copy link
Author

@enen92 - I see this issue has been closed, but is it because we need to first "extend the EDL interface and allow addons to set new edits" as part of a Kodi change? If that's the case, is there a Kodi issue tracking this feature request, or can I create one for it, in hopes of eventually re-opening this issue on the inputstream.adaptive side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants