Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPD] Wrong segment number calculated #560

Closed
matthuisman opened this issue Nov 25, 2020 · 5 comments · Fixed by #564
Closed

[MPD] Wrong segment number calculated #560

matthuisman opened this issue Nov 25, 2020 · 5 comments · Fixed by #564

Comments

@matthuisman
Copy link
Contributor

matthuisman commented Nov 25, 2020

Unix timestamp of test: approx 1606270484

kodi calculated segment: 383716778 (/video6/segment-383716778.m4s)
correct segment: approx 401567613 (/video6/segment-401567613.m4s)

Segments are 4s in length

Difference = 17,850,835 segments = 71,403,340 seconds (826 days)

The UTCTiming in the mpd file is correct to unix timestamp

MPD attached
manifest8.mpd.txt

@matthuisman matthuisman changed the title Wrong segment number calculate [MPD] Wrong segment number calculated Nov 25, 2020
@matthuisman
Copy link
Contributor Author

ok, so if I proxy and remove the presentationTimeOffset it calcs the correct segment (well 60 seconds off but thats due to UTCTiming vs publishTime)

Months ago, I had another mpd where the segment was calculate wrong (below is that mpd)
old_fixed.mpd.txt

That issue was fixed with this commit: dc7b427

That commit introduces parsing presentationTimeOffset which is causing the issue with this mpd.

@matthuisman
Copy link
Contributor Author

possible fix pr here:
#564

@CaptainTK
Copy link

By now most of the BBC's live programmes are affected by this, or a very similar, issue. Streams play fine in VLC, but inputstream.adaptive calculates incorrect (old) segments.

Given the large number of users of plugin.video.iplayerwww it would be highly appreciated if this issue would be addressed as quickly as possible.

@matthuisman
Copy link
Contributor Author

@CaptainTK
Copy link

A quick test looks good to me, @matthuisman. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants