darwin, fixed, compiler warning. DarwinUtils.h is C linkage so you sh…

…ould not be using C++ objects as return or params
xbmc · Oct 27, 2013 · 154733c · 154733c
1 parent 07b6910
commit 154733c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/xbmc/osx/DarwinUtils.h b/xbmc/osx/DarwinUtils.h
@@ -38,7 +38,7 @@ extern "C"
   float       GetIOSVersion(void);
   int         GetDarwinFrameworkPath(bool forPython, char* path, uint32_t *pathsize);
   int         GetDarwinExecutablePath(char* path, uint32_t *pathsize);
-  const std::string& DarwinGetXbmcRootFolder(void);
+  const char *DarwinGetXbmcRootFolder(void);
   bool        DarwinIsIosSandboxed(void);
   bool        DarwinHasVideoToolboxDecoder(void);
   int         DarwinBatteryLevel(void);

diff --git a/xbmc/osx/DarwinUtils.mm b/xbmc/osx/DarwinUtils.mm
@@ -277,7 +277,7 @@ int  GetDarwinExecutablePath(char* path, uint32_t *pathsize)
   return 0;
 }
 
-const std::string& DarwinGetXbmcRootFolder(void)
+const char* DarwinGetXbmcRootFolder(void)
 {
   static std::string rootFolder = "";
   if ( rootFolder.length() == 0)
@@ -294,7 +294,7 @@ int  GetDarwinExecutablePath(char* path, uint32_t *pathsize)
       rootFolder = "Library/Preferences";
     }
   }
-  return rootFolder;
+  return rootFolder.c_str();
 }
 
 bool DarwinIsIosSandboxed(void)

diff --git a/xbmc/settings/AdvancedSettings.cpp b/xbmc/settings/AdvancedSettings.cpp
@@ -420,7 +420,7 @@ void CAdvancedSettings::Initialize()
     #if defined(TARGET_DARWIN_OSX)
     logDir += "/Library/Logs/";
     #else // ios/atv2
-    logDir += "/" + DarwinGetXbmcRootFolder() + "/";
+    logDir += "/" + CStdString(DarwinGetXbmcRootFolder()) + "/";
     #endif
     m_logFolder = logDir;
   #else