Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subtitles] Don't search for external subtitles when opening a LiveTv input stream #1342

Merged
merged 2 commits into from Sep 1, 2012

Conversation

ace20022
Copy link
Member

This commit also modifies the check from 6 ifs to 1 if with a disjunctive condition and removes a commented line.

vdrfan@ pointed me to this at PR #1337.

@opdenkamp
Copy link
Member

change itself looks fine, but could you split out the cosmetics into a separate commit

This commit also modifies the check from 6 ifs to 1 if with a disjunctive condition.
@ace20022
Copy link
Member Author

Two more things:

  • What about isMythTv() and isTuxBox(), and maybe others?
  • The wiki entry http://wiki.xbmc.org/index.php?title=Subtitles#Compressed_subtitles states that the name of the archive has to be the name of the video file. This is not the case, any archive in the search path is examined. Furthermore, besides rar also zip is supported and there is no option to "automatically turn on packed subtitles".

elupus added a commit that referenced this pull request Sep 1, 2012
[subtitles] Don't search for external subtitles when opening a LiveTv input stream
@elupus elupus merged commit 131a574 into xbmc:master Sep 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants