Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking a screenshot via a gamepad doesn't play sound #15031

Open
EmilVogt opened this issue Dec 10, 2018 · 2 comments
Open

Taking a screenshot via a gamepad doesn't play sound #15031

EmilVogt opened this issue Dec 10, 2018 · 2 comments
Assignees
Labels
Component: Input Triage: Confirmed issue has been reproduced by a team member

Comments

@EmilVogt
Copy link
Contributor

Bug report

Describe the bug

I got myself a gamepad from Thrustmaster called Dual Analog 4. When pressing the button on the gamepad for "Screenshot" (in my case the left analog stick), Kodi takes a screenshot. That is good. However, in comparison to the keyboard combination Ctrl + S, taking a screenshot via the gamepad does not play the "flash" sound. So there's no feedback to what just happened.

Expected Behavior

When taking a screenshot via the gamepad, you should hear the flash (or shutter?) sound a real camera would make.

Actual Behavior

A screenshot is taken without any notice.

Possible Fix

Play a sound to have some feedback.

To Reproduce

  1. connect a gamepad
  2. in Kodi, press the button on the gamepad (left analog stick) to take a screenshot

Debuglog

The debuglog can be found here:
https://paste.kodi.tv/eqajohurup.kodi

Additional context

I was testing out the buttons on my gamepad to see what they do. When pressing the left analog stick, I ran into #15030. That means, the "select folder" dialog popped up twice and I didn't know why. Having the sound (which is there when using the keyboard shortcut) helps understanding what Kodi is supposed to do after pressing the button.

Your Environment

Operating system version/name: Windows 10 (1803), 64bit
Kodi version: 18 (Leia) RC2, 64bit

@lrusak
Copy link
Contributor

lrusak commented Dec 10, 2018

@garbear I'm pretty sure this is just related to the issue behind no gui sounds from gamepads/joysticks but I couldn't find the relevant issue to link to.

@garbear
Copy link
Member

garbear commented Dec 11, 2018

I never finished enabling GUI sounds for controllers. This is because GUI sounds are currently integrated with the keyboard. Once this dependency is fixed we can proceed with GUI controller sounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Triage: Confirmed issue has been reproduced by a team member
Projects
None yet
Development

No branches or pull requests

3 participants