Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skinning - ListItem infolabels in nested variables do not populate when a dialog is visible. #15348

Closed
2 of 7 tasks
jurialmunkey opened this issue Jan 27, 2019 · 6 comments · Fixed by #21303
Closed
2 of 7 tasks
Labels
Component: Skin Resolution: Fixed issue was resolved by a code change Triage: Has proposed fix Issue has been reproduced and has a pending proposed fix v19 Matrix v20 Nexus

Comments

@jurialmunkey
Copy link

Bug report

Describe the bug

If a listitem infolabel is in a variable nested in another variable, then the info will not show when a dialog such as contextmenu is on screen.

Expected Behavior

The info will show even if a dialog is on screen.

Actual Behavior

The info does not show.

To Reproduce

Steps to reproduce the behavior:

  1. Add a label control in MyVideoNav which references a variable:
<control type="label">
<label>$VAR[var_foo]</label>
</control>

In an includes file add the variable:

<variable name="var_foo">
<value>$VAR[var_bar]</value>
</variable>

<variable name="var_bar">
<value>$INFO[ListItem.Label]</value>
</variable>

The label will show when the library is visible. Open the context menu and it disappears. However, if you reference $VAR[var_bar] directly from the label control instead, then the info will stay.

Additional context

Nested variables help cut down on code sizes considerably. For instance, it is necessary to nest a variable that converts audio channel numbers into the correct speaker configuration (e.g. 2 = 2.0, 3 = 2.1, 4 = 3.1 etc.). Without a nested variable, complex labels need a condition for every single possible configuration.

Your Environment

Used Operating system:

  • Android
  • iOS
  • Linux
  • OSX
  • Raspberry-Pi
  • Windows
  • Windows UWP

The bug happens on Linux (Fedora), Windows 10, and Libreelec. (i.e. not platform dependent).

  • Kodi version: RC5.2

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

@ronie
Copy link
Member

ronie commented Jan 28, 2019

i can't reproduce this..
i've tested with estuary / current master / linux

@jurialmunkey
Copy link
Author

jurialmunkey commented Jan 28, 2019

@ronie - Sorry, my mistake. I meant Home.xml not MyVideoNav.xml

I just retested with the code above on Home and I can definitely reproduce this bug in Estuary with latest nightly. Highlight a movie and the label will show. Open the context menu and the label disappears.

It works in the library, but not on Home or in a Custom window.

@ronie
Copy link
Member

ronie commented Jan 29, 2019

yup, that i can reproduce.
i've no clue what might be causing it.

@thexai thexai added the Issue Cleanup: Obsolete This issue is no longer relevant and is now closed. label Apr 20, 2022
@thexai thexai closed this as completed Apr 20, 2022
@jurialmunkey
Copy link
Author

@thexai - Why is this issue obsolete? The bug still persists in the skinning engine in Matrix and I assume also Nexus (unless there is a PR that solves it which I am unaware of)

@thexai thexai removed the Issue Cleanup: Obsolete This issue is no longer relevant and is now closed. label Apr 21, 2022
@thexai thexai reopened this Apr 21, 2022
@enen92
Copy link
Member

enen92 commented Apr 22, 2022

I've tested this in nexus (placing the label on Home.xml and the variable definition on variables.xml and I Can't reproduce the issue:

Screenshot from 2022-04-22 12-59-33

@enen92
Copy link
Member

enen92 commented Apr 22, 2022

Nevermind, confirmed it now. I missed the context menu part.

@enen92 enen92 added the Triage: Has proposed fix Issue has been reproduced and has a pending proposed fix label Apr 25, 2022
@thexai thexai added the Resolution: Fixed issue was resolved by a code change label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Resolution: Fixed issue was resolved by a code change Triage: Has proposed fix Issue has been reproduced and has a pending proposed fix v19 Matrix v20 Nexus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants