ExternalPlayer::getTime() function is broken

[bigretromike]

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

When using external player via playercorefactory.xml before Leia Kodi would report 1.0 as watched (https://forum.kodi.tv/showthread.php?tid=331041). Right now even when isExternalPlayer() returns true the position with getTime() returns 0 all the time with our without setting <playcountminimumtime> in playercorefactory.xml

Expected Behavior

Here is a clear and concise description of what was expected to happen:
When using ExternalPlayer getTime() should return 1.0 when default <playcountminimumtime> or user defined value would be reached.

Actual Behavior

Using ExternalPlayer and looping with getTime() after onPlayBackStarted while checking isPlayingVideo results always with 0.

Possible Fix

Probably somewhere around here: yol@fc14587 someone forgot to add that 1.0 mark that was working before.

To Reproduce

Steps to reproduce the behavior:

1. Configure external player with playcountminimumtime set to small number 10/20
2. Use any addon that play video
3. Start looping with printing player.getTime() to log
4. Start playing video
5. Wait until you reach the minimumtime plus some extra time to be double sure

Debuglog

The debuglog can be found here:
Debug.log

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

• Android

• iOS

• Linux

• OSX

• Raspberry-Pi

• Windows

• Windows UWP

• Operating system version/name:

• Kodi version: 18.2 stable

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.