Skin settings to a button in Appearance, under skin chooser #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2012 16:22
…Settings.xml is available in the skin. Skinners should move their skin settings into this file, and remove links to skin settings elsewhere if they are no longer required.
|
As I said on irc I'm good on this |
|
+1 for Frodo since it's back-compat |
ghost
pushed a commit
that referenced
this pull request
Oct 15, 2012
Skin settings to a button in Appearance, under skin chooser
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided at devcon, get rid of the confusing button "Skin" on the main settings screen - user goes to Appearance to change things regarding the skin, including skin settings.
Fully backward compatible to skins that don't wish to use the facility - SkinSettings.xml is checked for and the button disabled if not available.
Skinners should probably switch to this regardless - it just makes sense.