ListItem.Icon does not fallback to the default icon

[ronie]

when no thumbnail is available, ListItem.Icon should fallback to the default icon (ie. DefaultVideo.png)
this is currently broken for all video items (movies/tvshows/seasons/episodes/musicvideos).
most likely due to the same issue, ListItem.ActualIcon returns empty as well.

it works fine for music items.

Leia:

Matrix:

pinging @enen92 / @DaveTBlake , iirc you have been making code changes in this area..

[DaveTBlake]

This could be a consequence of #16444 moving the default icon into art array. I did a follow-up fix for music as there were regressions where Kodi was using an empty art test, and art was now not empty. But video was not effected in the same way so I didn't touch that.

Is this change to Estuary #17035 intended as a fix for this, or just a work around, or something else?

[ronie]

thanx for looking into it.
the Estuary change is unrelated to this issue.

[ronie]

@enen92 any ideas?

[enen92]

@ronie can you provide some info on how to easily reproduce the issue? I'll definitely try to fix it if caused by my PR.

Added a .strm file to the library (The Social Network) and removed the items from the art table in MyVideos116.db but default icon is correctly filled:

Sorry for the delay, I need to enable email notifications for mentions.

Maybe send me a database where this issue is verified and let me know the item?

[ronie]

here's the database, it has just 1 tv show:
MyVideos116.db.zip

as mentioned on slack, the issue is noticeable in the 'widelist' view of estuary.

[enen92]

Ok I confirm the issue. I was not able to reproduce before because I removed all art items in the art table specific to the tvshow or movie. In your case you have an empty thumb/poster but still have a valid fanart.
I'll come up with a fix.