Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Substitution is not filtered in advancedsettings.xml #18974

Closed
6 tasks
SkyBird1980 opened this issue Dec 23, 2020 · 3 comments
Closed
6 tasks

Path Substitution is not filtered in advancedsettings.xml #18974

SkyBird1980 opened this issue Dec 23, 2020 · 3 comments
Assignees
Labels
Component: Logging Triage: Confirmed issue has been reproduced by a team member v19 Matrix

Comments

@SkyBird1980
Copy link

Bug report

Describe the bug

Path Substution in advancedsettings.xml is not filtered. So if you transfer a log or debuglog the password will be visible.

Expected Behavior

  • User and Password is filtered and shown as ****

Actual Behavior

  • User and Password is visible.

Possible Fix

your part :)

To Reproduce

Steps to reproduce the behavior:
Just add an smb pathsubstitution to advancedsettings.xml with user and password

Debuglog

The debuglog can be found here:
kodi.log

Screenshots

Here are some links or screenshots to help explain the problem:
-nothing to see here -

Additional context or screenshots (if appropriate)

-none-

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • OSX

  • [X ] Windows

  • Windows UWP

  • Operating system version/name: Windows 10 - 20H2

  • Kodi version: (19.0-BETA2 (18.9.821) Git:20201215-30abc954c7) (but is same on all versions i know before)

@DaVukovic
Copy link
Member

Thanks for the report 👍

@DaVukovic DaVukovic added Component: Logging Triage: Confirmed issue has been reproduced by a team member v19 Matrix labels Dec 23, 2020
@wsnipex wsnipex self-assigned this Jan 10, 2021
@basilgello
Copy link
Collaborator

Maybe URLs should be mangled too? For ex, paths to samba shares etc.

@wsnipex
Copy link
Member

wsnipex commented Jan 10, 2021

that is exactly what this does.
it replaces all occurrences of [protocol://]user:pass@[host].* with [protocol://]USERNAME:PASSWORD@[host]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Logging Triage: Confirmed issue has been reproduced by a team member v19 Matrix
Projects
None yet
Development

No branches or pull requests

4 participants