Core context menu bug

[roidy]

Bug report

Describe the bug

In my Library View I have my main Library container and also a secondary container with other related content. The problem is that for items in the main library view I can press 'c' and the context menu pops up fine, however the context menu wont appear for items in the secondary container when pressing 'c'

The problem gets stranger when I highlight an item in the secondary container using a mouse and then press the right mouse button and the context menu for that item pops up fine.

So the issue isn't that the context menu doesn't work/exist for the secondary container but that you can't access it using the 'c' key or any context menu button on a remote.... but you can access it using a right mouse click.

Expected Behavior

Context menu should be available in any container when pressing 'c' or the context menu button of a remote control, not just with a right click of a mouse

Actual Behavior

For non library containers context menu can only be accessed using a mouse and not with a keyboard/remote

Possible Fix

To Reproduce

Steps to reproduce the behavior:
This problem can be easily demoed using the Amber skin:-

1. Set your TV Show view to 'Triple' then highlight any tv show item in the first column using a keyboard/remote and press 'c' to correctly bring up the context menu.
2. Now move over to either the season or episode column using the remote/keyboard and press 'c' the context menu wont appear.
3. Now using a mouse highlight an item from either seasons or episodes and right click and the context menu appears perfectly fine.

Debuglog

The debuglog can be found here:
https://pastebin.com/gcAeMd2p

Screenshots

Here are some links or screenshots to help explain the problem:

Here's two videos that perfectly demonstrate the issue.

Video 1 Using a remote control the context menu is only accessible on the first list
https://streamable.com/uebp0v

Video 2 Using a mouse the context menu is accessible on all three lists
https://streamable.com/v3oy6y

Your Environment

Used Operating system:

• Android

• iOS

• tvOS

• Linux

• OSX

• Windows

• Windows UWP

• CoreElec

• Operating system version/name: Windows 10 64bit, CoreELEC

• Kodi version: 19.1 and 20

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

[enen92]

Hey @roidy, I was able to reproduce.
The following patch should fix the issue: 6542b20

I am not sure of any side effects though. Git blame says this is really ancient code (imported from svn), I don't think it makes any sense to block the event propagation specially if mouse right also follows the same path.
Would be nice if you could stress test this, if no side effects are found I'll PR the fix.

Thanks

[roidy]

@enen92 Thanks, that fixes the issue and after testing the context menu in multiple windows in Kodi I can see no issues or side effects.

I have only tested using Kodi 19.2 under Windows as that is the only version I can currently build, I can't get Kodi 20 to build but that's another unrelated issue, however I see no reason why this shouldn't also work in Kodi 20.

Again big thanks.