Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ListItems for TV Show/Movie Age Ratings #20689

Open
pkscout opened this issue Dec 16, 2021 · 0 comments
Open

New ListItems for TV Show/Movie Age Ratings #20689

pkscout opened this issue Dec 16, 2021 · 0 comments
Labels
Roadmap ticket on the Team roadmap

Comments

@pkscout
Copy link
Member

pkscout commented Dec 16, 2021

Roadmap or todo item

Detailed Description

Currently Kodi uses one field for Movie/TV Show age ratings (like G, PG, etc for the US). The proposal is to provide three new ListItems (or one ListItems with sub-items, I'm not sure technically which it is) for that information:

  • ListItem.Classification(Country): A text field for the ISO 3166-1 Alpha3 Code for the country of origin for the age rating for a given TV show or movie.
  • ListItem.Classification(Rating): A text field for the age rating for a given TV show or movie.
  • ListItem.Classification(Prefix): A text field for a user specified prefix for the rating (i.e. in the US many ratings are shown with "Rated" as a prefix.

The current ListItem.Mpaa should be depreciated for Kodi 20 for potential removal in Kodi 21.

This change would also require changes to NFO parsing so that people using NFO files could use the new fields. The two default Python scrapers (TMDb TV Shows and The Movie Database Python) would be updated to populate the three new fields (and continue populating the ListItem.Mpaa field at least for Kodi 20). Other non-core scrapers (like the TVDB and TVMaze scrapers) would be encouraged to update as well. The XML scrapers do not necessarily need to be updated, as their use is being discouraged.

There are some other recommended behaviors for the scrapers (to make them consistent):

  1. US Ratings should be used as a fall back if no rating for the selected country is available.
  2. As noted above, the ISO 3166-1 Alpha3 Code should be stored for the country of origin. Scrapers may need to convert the Aplha2 code if that is what is provided by the source service.
  3. Prefix would be optional (via a user setting) and default to empty.
  4. The Rating would be the string returned from the service source. The TVDb, for instance, includes the prefix "TV" for countries where TV show ratings are different from movie ratings.

There may yet need to be conversation about whether (or how) we might convert the current ListItem.Mpaa field to the three field format. Or, alternatively whether we might write a routine to lookup every TV show and movie in the person's library to update that information either as a separate add-on or a conversion task during a Kodi 20 upgrade.

Context

Right now the single ListItem.Mpaa field has a haphazard mix of data. Some scrapers just put in the rating. Some put in the country and rating, but only for non-US ratings. Others also allow users to add an arbitrary prefix. While that is fine for skins displaying the rating as text, those that attempt to provide images have to have very complicated logic for image names. With the new three field setup, we could standardize image names as <countrycode>-<rating>.<imgtype> while also allowing skins to show the text in ways appropriate for the skin.

Possible Implementation

Additional context, screenshots or links

Note: Team Kodi is considering this item, but we are not making any promises if and when it will be included.

@fuzzard fuzzard added this to To do in General (roadmap) via automation Dec 16, 2021
@enen92 enen92 added the Roadmap ticket on the Team roadmap label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap ticket on the Team roadmap
Projects
Development

No branches or pull requests

2 participants