master fails to build with FFmpeg >=5.0

[marv]

Bug report

Describe the bug

Building against FFmpeg 5.1 fails because some deprecated APIs have been removed and some gained const specifiers:

[...]
/var/tmp/paludis/build/media-kodi-scm/work/kodi-scm/xbmc/cores/AudioEngine/Encoders/AEEncoderFFmpeg.cpp:281:13: error: 'avcodec_encode_a
udio2' was not declared in this scope; did you mean 'avcodec_encode_subtitle'?
  281 |   int ret = avcodec_encode_audio2(m_CodecCtx, pkt, frame, &got_output);
      |             ^~~~~~~~~~~~~~~~~~~~~
      |             avcodec_encode_subtitle
/var/tmp/paludis/build/media-kodi-scm/work/kodi-scm/xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAE.cpp: In member function 'virtual IA
E::SoundPtr ActiveAE::CActiveAE::MakeSound(const std::string&)':
/var/tmp/paludis/build/media-kodi-scm/work/kodi-scm/xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAE.cpp:3051:33: error: invalid conversion from 'AVInputFormat**' to 'const AVInputFormat**' [-fpermissive]
 3051 |   av_probe_input_buffer(io_ctx, &io_fmt, file.c_str(), nullptr, 0, 0);
      |                                 ^~~~~~~
      |                                 |
      |                                 AVInputFormat**
[...]

Expected Behavior

The build should succeed

Actual Behavior

The build errors out

Possible Fix

Port to FFmpeg 5, examples:

• FFmpegAudioReader: fix build with newer ffmpeg versions acoustid/chromaprint#116
• gkv311/sview@a255e0d

To Reproduce

Steps to reproduce the behavior:

1. Install FFmpeg >= 5.0
2. Configure kodi build using FFmpeg >= 5.0
3. Start build

Debuglog

The debuglog can be found here:
kodi-scm.log

Your Environment

Used Operating system:

• Android

• iOS

• tvOS

• Linux

• OSX

• Windows

• Windows UWP

• Operating system version/name: Exherbo Linux

• Kodi version: master branch @ 8a85a4c

[lrusak]

Already known and being worked on internally by the team.

Ref: #21248

[marv]

Already known and being worked on internally by the team.

Cool, thanks for the info, it's good to know that's it's being worked on already!

What's the current progress? Is there already something I could test and give you feedback on?

[KjellRanda]

Same problem om Fedora 37:

/data/kodi/xbmc-20.0b1-Nexus/xbmc/cores/AudioEngine/Encoders/AEEncoderFFmpeg.cpp:281:13: error: ‘avcodec_encode_audio2’ was not declared in this scope; did you mean ‘avcodec_encode_subtitle’?
281 | int ret = avcodec_encode_audio2(m_CodecCtx, pkt, frame, &got_output);

rpm -qa|grep ffmpeg-
ffmpeg-libs-5.1.2-3.fc37.x86_64
ffmpeg-5.1.2-3.fc37.x86_64
ffmpeg-devel-5.1.2-3.fc37.x86_64

[lrusak]

You can enable using the internal ffmpeg with the cmake option -DENABLE_INTERNAL_FFMPEG=ON

Otherwise I'm closing this as it's know and there is a PR that fixes it (for v21) or you can just build with internal ffmpeg as stated above.