Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Quick fix/workaround for empty channel/guide window when used a… #22389

Merged
merged 1 commit into from Jan 4, 2023

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Jan 4, 2023

…s startup window due to missing window content refresh after PVR Manager started.

Supersedes #22374.

This is a quick fix with low regression risk. The root cause of the problem is identified but fix is rather high effort. Therefore we will go with a quick fix for now and I put the real fix on my todo list.

Root cause: When used as a startup window, loading window content must be deferred until the component responsible to deliver the data for the window is fully initialized. PVR startup is async. This logic is currently (maybe always was broken). Details are discussed in #22374.

Runtime-tested by me and @emveepee

@phunkyfish please review.

…s startup window due to missing window content refresh after PVR Manager started.
@ksooo ksooo merged commit c66a374 into xbmc:master Jan 4, 2023
@ksooo ksooo deleted the pvr-fix-startupwindows branch January 4, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Component: PVR Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants