Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolby Vision Tone Mapping #22411

Closed
satmandu opened this issue Jan 6, 2023 · 4 comments
Closed

Dolby Vision Tone Mapping #22411

satmandu opened this issue Jan 6, 2023 · 4 comments

Comments

@satmandu
Copy link
Contributor

satmandu commented Jan 6, 2023

Dolby Vision files are now supported with tone mapping (so they can be watched on non-HDR displays) in Jellyfin as per https://www.reddit.com/r/jellyfin/comments/v2nudu/dolby_vision_to_sdr_hwa_tonemapping_is_coming using GPU acceleration & ffmpeg 5.x.

Jellyfin does it server-side... but that's effectively the same as doing the conversion in Kodi when Kodi is playing the video.

It would be nice to get that support in Kodi. (Especially since Kodi is a popular front-end for Jellyfin.)

(This is separate from actually supporting Dolby Vision files, which is as per #22408 almost all there.)

@quietvoid
Copy link
Contributor

quietvoid commented Jan 6, 2023

An option is to use FFmpeg with vf_libplacebo, libplacebo should be available on most Linux distros.
However it is Vulkan only and FFmpeg is unlikely to be packaged with the options for it.

So the possible clients are quite limited at the moment.

The Jellyfin approach requires the changes to be in the FFmpeg fork, while vf_libplacebo is already upstream.

I'd guess having a libplacebo renderer would be much more effort than plugging in a filter.

@satmandu
Copy link
Contributor Author

satmandu commented Jan 6, 2023

via https://github.com/haasn/libplacebo: "libplacebo currently supports Vulkan (including MoltenVK), OpenGL, and Direct3D 11. It contains backwards compatibility code for very old versions of GLSL down to GLES 2.0 and OpenGL 1.3 and very old Direct3D feature levels down to 9_1."

@satmandu
Copy link
Contributor Author

satmandu commented Jan 6, 2023

I guess jellyfin is using their own ffmpeg fork: https://github.com/jellyfin/jellyfin-ffmpeg

(But so is kodi, no?)

Would it help to try to get those changes pushed upstream?

@satmandu
Copy link
Contributor Author

satmandu commented Jan 6, 2023

Looks like there are a bunch of dv fixes which have been added there, looking at https://github.com/jellyfin/jellyfin-ffmpeg/commits/jellyfin ...

@fuzzard fuzzard closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants