Incorrect nfo file crashes Kodi

[Daywalker84]

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

If the attached NFO file is read via local Info Only and then KODI is restarted, the application crashes within a few seconds.
MyVideos119 .txt
SafeWord2022.txt
kodi_crashlog-19.2 Git_20211006-52c19a0728-20230720-205724.txt

Expected Behavior

Here is a clear and concise description of what was expected to happen:

The application should not crash if an NFO file is corrupted

Actual Behavior

After scraping with local info only and restarting the application, it crashes

Possible Fix

After deleting the MyVideos119 file (v19) resp. MyVideos121 file (v20), the application can be started again without crashing

To Reproduce

Steps to reproduce the behavior:

My procedure:

1. set the scraper to "Local NFO only
2. after reading the file go to the Bib to see if the movie is in there (Bib is completely empty before = 0 movies)
3. close Kodi
4. start Kodi...Kodi crashes after a few seconds.
5. delete MyVideos119.db -> Kodi can be started again without problems

Debuglog

The debuglog can be found here:
https://paste.kodi.tv/bixogurili.kodi

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

• Android

• iOS

• tvOS

• Linux

• macOS

• Windows

• Windows UWP

• Operating system version/name:

• Kodi version: 19.2; 19.3 & 20.2

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

[KarellenX]

@Daywalker84

What is incorrect about the nfo file?
Your log does not show any crashing. It also shows you are using Kodi v20.2, so MyVideos119 does not apply.

[Daywalker84]

Yes, the error first occurred under v19, -->MyVideos119.
I was also able to reproduce it with v20.2, therefore see MyVideos121.
MyVideos121.txt

I don't know how it happened, but under the originaltitle tag it says the following: ????!.
I suspect that this is the reason why the crash occurs later. I have a second file where there is something else under the tag, and there are no problems here.
SafeWord2022_Error.txt
SafeWord2022_OK.txt

My main concern is that the application does not crash because of a incorrect nfo file.
I hope you can reproduce it with SafeWord2022_Error.txt or MyVideos121.txt.

[KarellenX]

I don't see anything wrong with the nfo file.
It does not crash for me.
Which scraper are you using?
I don't know where the ?????! came from. I've never seen that before.

I would need a debug log that captures the crash to investigate further.

[Daywalker84]

To reproduce this error I use as already written in the description only the "local information only pseudo-scraper".
So that there is no misunderstanding, when scrapping there are no problems, but afterwards when Kodi is restarted...it comes to a crash:
KodiDebbugLog1 - scraping with Local Information only pseudo-scraper.log
KodiDebbugLog2 - After restart application crashed.log

[kodi_stacktrace-20.2 Git_20230629-5f418d0b13-20230725
kodi_crashlog-20.2 Git_20230629-5f418d0b13-20230725-101301.txt
-101301.txt](https://github.com/xbmc/xbmc/files/12158825/kodi_stacktrace-20.2.Git_20230629-5f418d0b13-20230725-101301.txt)

[KarellenX]

I think it is the service.library.data.provider addon causing you the problem.
You can't disable this Service, so you will need to delete the addon.
Exit Kodi
Go to C:\Users\axelk\AppData\Roaming\Kodi\addons
Delete service.library.data.provider folder.
Restart Kodi. Does it still crash?

[Daywalker84]

After deleting the folder, the application does not crash.
But what are the consequences?
What is this "service" responsible for?

[KarellenX]

It is used by the skin. Aeon Nox Silvo in your case. Here is the source... https://github.com/MikeSiLVO/service.library.data.provider
Best to ask in the Aeon Nox Silvo forum for further help.
It can always be reinstalled from the skin settings page. Maybe try doing that first to rule out a simple corruption problem. But if you are not noticing any difference in the way the skin is operating, maybe it wasn't being used.