Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error <align>right</align> at line break [CR] #24725

Closed
1 of 7 tasks
Fuchs246 opened this issue Feb 17, 2024 · 6 comments · Fixed by #24799
Closed
1 of 7 tasks

Error <align>right</align> at line break [CR] #24725

Fuchs246 opened this issue Feb 17, 2024 · 6 comments · Fixed by #24799
Labels
Resolution: Fixed issue was resolved by a code change

Comments

@Fuchs246
Copy link

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

When using a line break, the entire text is no longer aligned to the right.
The longer text is aligned to the right.
The shorter text is aligned to the left, to the beginning of the longer text.

Nexus alignment correct:
screenshot00019

Nexus alignment not correct:
screenshot00017

Nexus alignment not correct:
screenshot00015

Expected Behavior

Here is a clear and concise description of what was expected to happen:

All text is aligned to the right.

Actual Behavior

Only the longest text is aligned to the right.

Possible Fix

Possible cause of this error:
#24624

To Reproduce

Steps to reproduce the behavior:

Debuglog

The debuglog can be found here:

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • macOS

  • Windows

  • Windows UWP

  • Operating system version/name: Windows10

  • Kodi version: Kodi 21 Omega beta3

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

@xbmc-gh-bot xbmc-gh-bot bot added the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label Feb 17, 2024
@Fuchs246
Copy link
Author

Oops, the screenshot should say “not correct” Omega.
Copy and paste error on my part.

@Ch1llb0
Copy link

Ch1llb0 commented Feb 19, 2024

Related to this one, @CastagnaIT? #24246

@CastagnaIT
Copy link
Collaborator

its possible
but to understand something is needed to see the xml code of the control that show the "bad" aligned text on screenshots above that has not been attached

@Fuchs246
Copy link
Author

its possible but to understand something is needed to see the xml code of the control that show the "bad" aligned text on screenshots above that has not been attached

Here is my xml code:

<control type="label">
<!--PlayerActionLabel-->
<animation type="Conditional" condition="player.paused | player.forwarding | player.rewinding">
<effect type="slide" start="0,0" end="-150,-5" time="200" tween="cubic" easing="inout" delay="0" />
</animation>
<right>60</right>
<posy>95</posy>
<width>890</width>
<align>right</align>
<font>Reg30</font>
<textcolor>$INFO[Skin.String(OSDPrimaryTextColor)]</textcolor>
<shadowcolor>$INFO[Skin.String(OSDPrimaryTextShadowColor)]</shadowcolor>
<label>$VAR[PlayerFinishTime,[B]$LOCALIZE[31112][/B][CR] ,]</label>
</control>

<control type="label">
<!--Total duration-->
<animation type="Conditional" condition="player.paused | player.forwarding | player.rewinding">
<effect type="slide" start="0,0" end="-150,20" time="200" tween="cubic" easing="inout" delay="0" />
</animation>
<right>60</right>
<posy>145</posy>
<width>890</width>
<align>right</align>
<font>Reg30</font>
<textcolor>$INFO[Skin.String(OSDPrimaryTextColor)]</textcolor>
<shadowcolor>$INFO[Skin.String(OSDPrimaryTextShadowColor)]</shadowcolor>
<label>$INFO[Player.Duration(h),[B]$LOCALIZE[180][/B][CR],h]$INFO[Player.Duration(mm),,min]</label>
</control>

@Fuchs246
Copy link
Author

Fuchs246 commented Mar 8, 2024

I made a fix, please give a feedback, you can choose one on these test builds

This change has fixed the error.

Tested with test version:
http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240304-78004ff5-truncate_text_edit-x64.exe

@thexai thexai added Resolution: Fixed issue was resolved by a code change and removed Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Fixed issue was resolved by a code change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants