Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

something wrong with rescale_L #1

Open
tadpole opened this issue Jan 28, 2018 · 1 comment
Open

something wrong with rescale_L #1

tadpole opened this issue Jan 28, 2018 · 1 comment

Comments

@tadpole
Copy link

tadpole commented Jan 28, 2018

To rescale Laplacian eigenvalues to [-1, 1], the formula should be $L' = 2L/l_max - I$.
I think the 33-th line in corsening.py should be like follows:

L /= lmax / 2
@zhujiagang
Copy link

zhujiagang commented Feb 24, 2018

@tadpole Your meaning is right, but your implementation may not be general. Perhaps it's the version of python or numpy that actually matters.
I change the original version to L = 2 * L / lmax , a possible version that is applicable to any version of code, the accuracy could achieve 99.080%.
But with your version L /= lmax / 2, loss could be nan and accuracy could be around 11%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants