Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in Axios retries. #12

Closed
javierbrea opened this issue Jun 27, 2019 · 2 comments · Fixed by #20
Closed

Infinite loop in Axios retries. #12

javierbrea opened this issue Jun 27, 2019 · 2 comments · Fixed by #20
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@javierbrea
Copy link
Member

javierbrea commented Jun 27, 2019

When an axios request fails, it is retried infinitely. This behavior has been reproduced with a 500 status code response.

A workaround is to set the retries option to 0.

Axios should retry requests only number of times defined in the retries option, and then fail.

After debugging the library code, it is maybe related with used versions of axios and axios-retry, or maybe with another dependency version causing an unexpected conflict. Options from mercury-api are being passed to axios-retry correctly.

@javierbrea
Copy link
Member Author

FYI @LunaFidalgo

@javierbrea javierbrea transferred this issue from XbyOrange/react-mercury Jun 27, 2019
@javierbrea javierbrea added this to To do in Mercury Api via automation Jun 27, 2019
@javierbrea javierbrea added the bug Something isn't working label Jun 27, 2019
@javierbrea javierbrea moved this from To do to In progress in Mercury Api Oct 17, 2019
@javierbrea javierbrea self-assigned this Oct 17, 2019
@javierbrea javierbrea added this to the v1.3.0 milestone Oct 17, 2019
@javierbrea
Copy link
Member Author

This issue is related with an issue of the "axios-retry" library: softonic/axios-retry#59

@javierbrea javierbrea moved this from In progress to Ready for release in Mercury Api Oct 17, 2019
This was referenced Oct 17, 2019
Mercury Api automation moved this from Ready for release to Done Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Mercury Api
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant