Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sonar code smells in demo #14

Closed
javierbrea opened this issue Jun 27, 2019 · 0 comments · Fixed by #17
Closed

Fix Sonar code smells in demo #14

javierbrea opened this issue Jun 27, 2019 · 0 comments · Fixed by #17
Assignees
@javierbrea
Labels
enhancement New feature or request
Projects
React Mercury

Comments

@javierbrea
Copy link
Member

Sonar has reported some code smells in the demo code.

https://sonarcloud.io/dashboard?id=xbyorange-react-mercury

It is desirable to fix them. No new release is necessary, because demo code is not published to NPM.
@javierbrea javierbrea added the enhancement New feature or request label Jun 27, 2019
@javierbrea javierbrea added this to To do in React Mercury via automation Jun 27, 2019
@javierbrea javierbrea moved this from To do to In progress in React Mercury Aug 13, 2019
@javierbrea javierbrea self-assigned this Aug 13, 2019
@javierbrea javierbrea mentioned this issue Aug 13, 2019
Merged
React Mercury automation moved this from In progress to Done Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javierbrea javierbrea

Labels
enhancement New feature or request
Projects
React Mercury
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V1.1.0 beta.1 XbyOrange/react-mercury
1 participant
@javierbrea