Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline mode #112

Closed
superyarik opened this issue Jul 9, 2020 · 8 comments
Closed

Offline mode #112

superyarik opened this issue Jul 9, 2020 · 8 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@superyarik
Copy link

as i see there is webview inside with external libs from CDN. so, it does't work in offline. Do you plain to include libs to bundle and making possible offline work?

@xcarpentier
Copy link
Owner

Maybe => #113

@xcarpentier xcarpentier added the enhancement New feature or request label Jul 9, 2020
@franknmungai
Copy link

So offline mode now fully works in the new upgrade, is it out in the latest npm version yet?

@stale
Copy link

stale bot commented Aug 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2020
@brianchenault
Copy link

This is a huge issue for me, as my app needs to support offline viewing of PDFs. Any update on this? Thanks!

@stale stale bot removed the wontfix This will not be worked on label Aug 13, 2020
@LordMilan
Copy link

So does the pdf works in offline mode now??? after making changes to index.tsx of rn-pdf-reader???

@xcarpentier
Copy link
Owner

No, don’t have time to do it, I’ll accept a PR

@stale
Copy link

stale bot commented Sep 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 26, 2020
@stale stale bot closed this as completed Oct 2, 2020
@xcarpentier xcarpentier reopened this Oct 2, 2020
@stale stale bot closed this as completed Oct 10, 2020
@stratoss
Copy link

@xcarpentier I'm pretty new to react, but can try to help out with the offline mode. Can you give me a quick hint around the tool-chain used to compile / test the code?

I can see that in the npm package rn-pdf-reader-js the problematic code is contained in lib/index.js while in this repo is located at src/index.tsx .

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

6 participants