Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log. #171

Closed
SupaMario123 opened this issue Mar 12, 2022 · 4 comments
Closed

Remove log. #171

SupaMario123 opened this issue Mar 12, 2022 · 4 comments
Labels
wontfix This will not be worked on

Comments

@SupaMario123
Copy link

Hello,
thank you very much for this awesome package! It solves my problem.
Just one note.
Please remove the Log "URL_TO_BASE64" every time displayed, when opening a pdf with it.

Thank you!

Bildschirmfoto 2022-03-12 um 14 25 52

@sylvio-ruiz
Copy link

Hello, thank you very much for this awesome package! It solves my problem. Just one note. Please remove the Log "URL_TO_BASE64" every time displayed, when opening a pdf with it.

Thank you!

Bildschirmfoto 2022-03-12 um 14 25 52

This is just a debug log before mount the component. You can avoid it going to your node-modules path/rn-pdf-reader-js/lib, opening the index.js and commenting the line around 229 :
componentDidMount() {
this.setState({ renderType: this.getRenderType() }, () => {
//console.debug(this.state.renderType);
this.validate();
this.init();
});
}

@SupaMario123
Copy link
Author

Thank you!
I dont have the log any more. Should i leave the "Issue" open for you as a reminder to remove log ?

@sylvio-ruiz
Copy link

Thank you! I dont have the log any more. Should i leave the "Issue" open for you as a reminder to remove log ?

I am happy to know.

I believe that you can leave it as it is. A flag to pass to the component as a prop to show logs is the best option. There are many others when something goes wrong but they are useful when we are developing and testing the code locally. A flag to disable the logs is welcome for production.

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 17, 2022
@stale stale bot closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants