Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph.RemoveText calls CreateEdit when trackChanges == false #59

Open
cfharp opened this issue Sep 7, 2016 · 2 comments
Open

Paragraph.RemoveText calls CreateEdit when trackChanges == false #59

cfharp opened this issue Sep 7, 2016 · 2 comments

Comments

@cfharp
Copy link

cfharp commented Sep 7, 2016

While using DocX in a plugin for CRM Online, I came across an error because I don't have privilege to get the current user. This shouldn't be an issue if track changes is off (and isn't an issue for Paragraph.InsertText as it checks trackChanges before calling Paragraph.CreateEdit). I'm thinking this may be a bug (not quite bug, but unnecessary), and that Paragraph.RemoveText should be similar to Paragraph.InsertText for calling CreateEdit. Avoiding this call should also avoid the call to get current user.

Paragraph.RemoveText lines of code: 3710 and 3748
Paragraph.InsertText lines of code: 2099 and 2119

@PrzemyslawKlys
Copy link
Contributor

Feel free to submit patch :)

@PrzemyslawKlys
Copy link
Contributor

If you could submit patch for this it would be nice. Code lines change and they don't match things anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants