Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: getSeed and BIP39 #107

Closed
thorchain-admin opened this issue Nov 20, 2020 · 0 comments · Fixed by #121
Closed

FIX: getSeed and BIP39 #107

thorchain-admin opened this issue Nov 20, 2020 · 0 comments · Fixed by #121
Assignees
@icafa

Comments

@thorchain-admin
Copy link
Contributor

thorchain-admin commented Nov 20, 2020 •
edited by veado

Fix these:

-crypto

  • remove the phrase length check in getSeed() Done Removes check of word length in getSeed #108
  • add a BIP39.validatePhrase(phrase) in getSeed()
  • add a BIP39.validatePhrase(phrase) in encryptToKeystore()
  • remove getAddress()
  • remove getPublicKeyPair()
  • remove pub keys from keystore meta-data

Downstream Clients
@icafa icafa mentioned this issue Dec 1, 2020
Merged
@icafa icafa closed this as completed in #121 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icafa icafa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix !107 xchainjs/xchainjs-lib
2 participants
@icafa @thorchain-admin