Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the way PBXGroup generates the comment for the children #169

Merged
merged 2 commits into from Nov 25, 2017
Merged

Fix the way PBXGroup generates the comment for the children #169

merged 2 commits into from Nov 25, 2017

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Nov 25, 2017 •
edited

Resolves #60

Short description 📝

PBXGroup used its internal method to generate the comments for the children. This method didn't check all the types that the child could refer to.

Solution 📦

Support group and versionGroup.

Implementation 👩‍💻👨‍💻

  • Use the method form PBXProj+Helpers.
  • Support group and versionGroup in that method.

GIF

gif

This change is Reviewable

@pepicrft pepicrft self-assigned this Nov 25, 2017
@pepicrft pepicrft requested a review from a team November 25, 2017 21:25
@pepicrft pepicrft changed the title [filereference-name] Fix the way PBXGroup generates the comment for the children Fix the way PBXGroup generates the comment for the children Nov 25, 2017
@pepicrft pepicrft merged commit bd89d23 into master Nov 25, 2017
@pepicrft pepicrft deleted the filereference-name branch November 25, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pepicrft pepicrft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pepicrft