Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow API URL and key to be passed directly to store and opener #3

Closed
pont-us opened this issue Sep 15, 2020 · 1 comment
Closed

Allow API URL and key to be passed directly to store and opener #3

pont-us opened this issue Sep 15, 2020 · 1 comment
Assignees
@pont-us
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pont-us
Copy link
Member

pont-us commented Sep 15, 2020

Currently, xcube-cds does not allow direct specification of the CDS API URL and key; the cdsapi Client class instead reads them directly from a configuration file or environment variables. It should be possible to pass the API URL and key directly to the CDSDataOpener and CDSDataStore constructor in cases where the configuration file and environment variable settings are not present or need to be overridden.
@pont-us pont-us added enhancement New feature or request good first issue Good for newcomers labels Sep 15, 2020
@pont-us pont-us self-assigned this Sep 15, 2020
@pont-us
Copy link
Member Author

pont-us commented Oct 7, 2020

Fixed in PR #11 .

@pont-us pont-us closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pont-us pont-us

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pont-us