Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clicking outside of <p> elements doesn't close popup #11

Open
turshija opened this issue Mar 10, 2015 · 3 comments
Open

[Bug] Clicking outside of <p> elements doesn't close popup #11

turshija opened this issue Mar 10, 2015 · 3 comments

Comments

@turshija
Copy link

For example I highlight a text in elements I've chosen, popup shows and if I click outside (for example on background), text gets de-selected but popup remains.

Image

@neuedeutsche
Copy link

yup noticed that too, needs a more general close event.

@dandv
Copy link

dandv commented Jun 3, 2015

Screencast

icon persists after clicking elsewhere

@dandv
Copy link

dandv commented Jun 3, 2015

Fixed in my fork of SelectionMenu that addresses a few other issues from selection-sharer and makes it general-purpose (i.e you can put anything you want in the menu).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants