Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken import #131

Closed
dbettini opened this issue Jan 22, 2019 · 4 comments
Closed

Broken import #131

dbettini opened this issue Jan 22, 2019 · 4 comments

Comments

@dbettini
Copy link

Jodit Version: 3.2.34, 3.2.33, 3.2.32

This commit has changed the way the library is exported. I'm guessing this was by mistake because I doubt it would be done on purpose in a patch version bump. Basically, it's now a named export instead of a default one. This breaks all projects that used Jodit previously and updated to the new version, and all libs that use it, for example jodit-vue.

Expected behavior:
Default export is used, so import Jodit from 'jodit' works as expected.

Actual behavior:
Named export is used, so import { Jodit } from 'jodit' must be used instead.

@crashkonijn
Copy link

No update on this? Kinda weird that this project got broken like this.

@dsmackie
Copy link

I use 3.2.44 and have no issue with import Jodit from 'jodit';.

@dbettini
Copy link
Author

@dsmackie It seems to be fixed as a part of a completely different bugfix, as a direct commit to master, without mentioning this issue in the commit 😄

@dbettini
Copy link
Author

Fixed in 3.2.43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants