Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code coverage CI take filecheck tests into account #241

Closed
webmiche opened this issue Nov 29, 2022 · 3 comments · Fixed by #256
Closed

Make code coverage CI take filecheck tests into account #241

webmiche opened this issue Nov 29, 2022 · 3 comments · Fixed by #256
Labels
CI Continuous Integration testing PRs that modify tests

Comments

@webmiche
Copy link
Collaborator

Maybe something with https://llvm.org/docs/CommandGuide/llvm-cov.html can be done.

@webmiche webmiche added testing PRs that modify tests CI Continuous Integration labels Nov 29, 2022
@webmiche webmiche changed the title Make Codecoverage CI take filecheck tests into account Make code coverage CI take filecheck tests into account Nov 29, 2022
@webmiche
Copy link
Collaborator Author

AFAIU, the provided link only helps in showing code coverage data. Looking at the lit documentation directly, they don't seem to be able to report code coverage metrics. While a package like coverage.py might be helpful, it does not work in this case as lit is it's own executable.

We might be able to run a sufficiently smart pytest program, that basically does what lit does atm (crawl over files, run the right commands), while also being introspectable. Though I feel that it might actually be easier to just expand our pytest suite to a point where we won't need the filecheck tests to get a reasonable high coverage.

@georgebisbas
Copy link
Contributor

Though I feel that it might actually be easier to just expand our pytest suite to a point where we won't need the filecheck tests to get a reasonable high coverage.

Exactly! :-)

@webmiche
Copy link
Collaborator Author

What I am not 100% sure about is whether this is actually possible/reasonable, in particular around xdsl-opt, as this is really intended to be run from the command line. This becomes particularly true for things around the mlir-converter. I guess we can write some weird tests to circumvent this though...

@webmiche webmiche linked a pull request Dec 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration testing PRs that modify tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants