Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor std into std and arith dialects. #29

Closed
Dinistro opened this issue Dec 25, 2021 · 2 comments · Fixed by #32
Closed

Refactor std into std and arith dialects. #29

Dinistro opened this issue Dec 25, 2021 · 2 comments · Fixed by #32
Assignees
@Dinistro

Comments

@Dinistro
Copy link
Collaborator

MLIR changed parts of their dialect structures by introducing an arith dialect. We should reflect this new dialect as well to ensure we stay compatible with MLIR.
@Dinistro Dinistro self-assigned this Dec 25, 2021
@Dinistro
Copy link
Collaborator Author

Dinistro commented Dec 25, 2021 •
edited
Loading

I guess we should wait until #26 is merged before we start to refactor these things.

@Dinistro Dinistro mentioned this issue Dec 25, 2021
Merged
@Dinistro
Copy link
Collaborator Author

Combining this with fixing the MLIR converter might be a good idea, as we cannot test this otherwise.

@Dinistro Dinistro mentioned this issue Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dinistro Dinistro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature arith dialect & Vector fix xdslproject/xdsl
1 participant
@Dinistro