Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin takes into account the commented part of deployit-manifest.xml and try to execute them #18

Closed
arisjramos opened this issue Dec 5, 2018 · 1 comment

Comments

@arisjramos
Copy link

The plugin takes into account the commented part of deployit-manifest.xml and try to execute the commented code !!

<?xml version="1.0" encoding="UTF-8"?>
<udm.DeploymentPackage version="${noSnapshot(project.warFromNexusVersion)}" application="${project.xl_deploy_app_id}">
    <deployables>
        <tomcat.War name="${project.xl_deploy_app_id}" file="${artifact(project.warFromNexus)}" >
            <tags>
                <value>${project.xl_deploy_app_id}</value>
            </tags>
            <contextRoot>${project.xl_deploy_app_id}</contextRoot>
        </tomcat.War>
        <hug.ClasspathFile name="${project.xl_deploy_app_id}-config-files" file="${artifact(project.zipConfig)}">
            <tags>${project.xl_deploy_app_id}</tags>
        </hug.ClasspathFile>
        <!--<hug.WorkdirFolder name="${project.xl_deploy_app_id}-application-files" file="${artifact(project.applicationFiles)}">
            <tags>
                <value>${project.xl_deploy_app_id}</value>
            </tags>
            <targetFolder>bin/mongodb</targetFolder>
        </hug.WorkdirFolder>-->
    </deployables>
</udm.DeploymentPackage>

The commented part of this file is still evaluated and executed and crashing with an error.

@byaminov
Copy link
Contributor

@arisjramos we use Groovy template engine to evaluate and replace ${..} placeholders in the XML template, and indeed it replaces any Groovy placeholder, even if it's encountered within an XML comment.

If you don't want those replacements to happen you need to comment out the ${..} placeholders too, for example by changing ${artifact(project.applicationFiles)} to $_{artifact(project.applicationFiles)}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants