Modified WinRM classes to work with IBM JDK #130
Conversation
|
XebiaLabs » overthere #216 SUCCESS |
|
Hi Hågen, Thanks for the PR. I've added a few small comments. If you could change them, I'm more than happy to merge it. Thx! |
|
|
||
| class JavaVendor { | ||
|
|
||
| private static final boolean IBM_JAVA = System.getProperty("java.vendor").contains("IBM"); |
There was a problem hiding this comment.
Minor about this one...do we know whether IBM here is always uppercase?
Also some minor style issues in this class: spacing and indents.
|
XebiaLabs » overthere #218 SUCCESS |
|
I have tried to make the appropriate changes based on your comments. |
|
I've been testing my changes in three different scenarios, one from Linux to Windows, and two from Windows to Windows. One of the Windows-scenarios got some kind of connection timeout problem when I tried to start a remote process just now. This scenario worked just fine before, so I might have done something wrong in the latest commit. I'll dig into it on monday, but please don't accept this pull request until I have investigated further. |
Thanks for the heads-up, @haagenhasle! Have a good weekend ;-) |
|
@haagenhasle Code looks fine, awaiting any changes you might have wrt the timeout issue. Let us know. |
|
I looked more closely at the scenario where I experienced a timeout, and in that case we actually used the Oracle JDK. I haven't figured out what caused the timeout yet (I've had to work on other things), but it shouldn't have anything to do with the changes in the pull request then. I can't guarantee that the code I wrote is perfect in any way, both Kerberos and the IBM JDK is quite new to me. But I think/hope it is a step in the right direction for Overthere on the IBM JDK. :) |
Modified WinRM classes to work with IBM JDK
|
@haagenhasle It's merged! Thanks for the contribution! |
|
Thanks, @haagenhasle! @hierynomus: Does any documentation need to be updated to describe these changes? |
We are using Overthere at work, and like it very much. But recently we swithced to the IBM JDK, and the Kerberos support in the internal WinRm implementation in Overthere doesn't work with the IBM JDK. I have done some modifications to make it work, and I hope these changes can be added to the next release of Overthere.