Added support for socket timeout in SshConnection. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unified winrm client socket timeout.
|
XebiaLabs » overthere #275 SUCCESS |
|
Hi Gionn, Think just plain unlucky with very unstable connections ;) |
|
Thanks for the PR :) I also fixed it for Telnet now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same feature I've added in the previously PR for winrm, this time for the ssh client (I don't know if we are particularly unlucky but we are getting tons of random network errors while using this library).
For this reason I've uniformed the parameter in a more generic socketTimeoutMillis.