Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the pattern used for ls commands (correctly handles ending '.', '+' or '@') #61

Merged
merged 1 commit into from
Nov 6, 2012

Conversation

pgmillon
Copy link
Contributor

@pgmillon pgmillon commented Nov 2, 2012

The pattern used to check permissions from the return of the ls command can only handle :

  • drwxrwxrwx
  • drwxrwxrwx@

It should be able to handle these :

  • drwxrwxrwx (normal)
  • drwxrwxrwx@ (Mac OS X)
  • drwxrwxrwx. (SELinux)
  • drwxrwxrwx+ (ACLs)

@buildhive
Copy link

XebiaLabs » overthere #57 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@vpartington
Copy link
Contributor

Hi Pierre-Gildas,

Thx for pull request! Extending the regular expression to handle the extra attributes added by SELinux and ACLs is a good idea.

Unfortunately, it's not possible to auto-merge the pull request so I'll manually resolve the conflicts and merge next week.

Have a good weekend, Regards, Vincent.

@vpartington vpartington merged commit a004e89 into xebialabs:master Nov 6, 2012
@vpartington
Copy link
Contributor

Hi Pierre-Gildas,

Just merged your pull request. Thx again!

Regards, Vincent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants