Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Directory and OverthereConnection.getFile(parent, child) #72

Closed
farrault opened this issue Feb 8, 2013 · 3 comments
Closed

Comments

@farrault
Copy link

farrault commented Feb 8, 2013

If I call OverthereConnection.getFile(parent, child) with a parent that is a temporary directory,
I get a non-temporary file.
(which is very problematic when using a sudo connection)

Don't you think, it would be preferable to constrain the parent to be a non-temporary one when calling this method ?

@hierynomus
Copy link
Contributor

Actually you make a good point. The file returned should be a temporary file if the parent is also a temporary file. It should exhibit the same behaviour as OverthereFile.getFile(String child). Which for a SshSudoFile inherits the 'temporaryness' from the parent.

@farrault
Copy link
Author

Please see my comments in the commit.
Regards

@hierynomus
Copy link
Contributor

Hi Fabien,

The "temporariness" was only used in the SshSudoConnection, so I pushed it down there. None of the other Ssh connection types actually differentiated between a regular file and a temporary one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants