Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameters from setState #23

Open
Lukenickerson opened this issue Feb 3, 2024 · 4 comments
Open

Remove unused parameters from setState #23

Lukenickerson opened this issue Feb 3, 2024 · 4 comments

Comments

@Lukenickerson
Copy link
Contributor

As far as I can tell, the setState function (https://github.com/xem/W/blob/gh-pages/w.js#L131) only uses the state, type, and texture parameters, and does not use i, normal = [], A, B, C, Ai, Bi, Ci, AB, BC.

@xem -- Can these be safely removed?

@xem
Copy link
Owner

xem commented Feb 3, 2024

Oh, nice catch! It seems so.

@xem
Copy link
Owner

xem commented Feb 7, 2024

Hi Luke, I saw your video and it's amazing. Let me know if you want to be an official contributor of this repo (with write access), or chat with me on telegram, whatsapp? I'd be happy to help you and improve W at the same time.

@Lukenickerson
Copy link
Contributor Author

Glad you like the video. Sure, I'd love to be a contributor! I'm also on Discord and WhatsApp.

@xem
Copy link
Owner

xem commented Feb 8, 2024

I added you :)
I've not coded a lot the past year, but slowly getting back to it.
There are features I'd like to add in W, like shadow casting, bump mapping, skybox, ...
I may start prototyping things like this in the future. In the meantime, I'm here if you have questions or critics, and I can't wait for the video #2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants