Move to mimalloc for rust. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge and rerun the tests on my machine, sounds like a good candidate for C version as well. I mean maybe it will be even better to show results for mimalloc flavors where it is suitable. |
morisil
approved these changes
Feb 6, 2021
| @@ -1,6 +1,9 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
I think it's worth restructuring the project in the future, once you will finish with your PRs. Each language has own specific build system, and it seems that we are going deeper and deeper into customization. So creating a folder for each language on the root level might be better than reusing java ecosystem convention of src/main/x. To be honest I didn't anticipate all the amazing contributions to this project so I couldn't foreseen that. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in a large speed up for rust as mimalloc is faster than the default allocator, I was thinking that this should be ok as kotlin native is also specified to use mimalloc?